Fix NULL pointer in pdal translate --polygon
#740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crop_stage was being initialized to a (zero literal) NULL pointer, and was never updated to a real Stage *. This led to a segfault when trying to crop to a polygon with `pdal translate` (and probably would cause segfaults in other situations as well). Rather than creating a StageFactory in a third place in the same method, I just made a method-wide stage factory — losing possible efficiency in favor of simplicity. This patch does not include any unit tests, since AFICT there aren't any unit tests for kernels.
hobu
added a commit
that referenced
this pull request
Feb 1, 2015
Fix NULL pointer in `pdal translate --polygon`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crop_stage was being initialized to a (zero literal) NULL pointer, and was never updated to a real Stage *. This led to a segfault when trying to crop to a polygon with
pdal translate(and probably would cause segfaults in other situations as well).Rather than creating a StageFactory in a third place in the same method, I just made a method-wide stage factory — losing possible efficiency in favor of simplicity.
This patch does not include any unit tests, since AFICT there aren't any unit tests for kernels.