-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add passthrough filter #743
Conversation
Just to clarify, this is not intended to be a full replacement for Python, just a small subset for simple filtering. |
Could this be called |
I have no strong feeling on the name. Passthrough is just the analogue in PCL. |
ah, that's fine to keep it aligned then. I think our challenge is that |
I still have it in the back of my head to possibly split the filters from the non-filters. I struggle a little with what to call the non-filters. I believe @abellgithub proposed "operations" or something similar. |
My two cents: |
Discussed offline -- this basically just filters a range, and we don't have plans to make it any more complicated than that, so call it a range filter. |
cca3b0e
to
f85693f
Compare
This could obviously be more complicated, but as it is, I think it's a nice alternative to the Python filters. The documentation, sample pipeline, and unit tests should adequately explain the current feature set (basically multi-dimensional, min/max/exact value criteria for passing points through to the output buffer).
f85693f
to
6f8d6b2
Compare
I'd missed a file rename on this. Otherwise, assuming it passes Travis, it's all ready to go. |
This could obviously be more complicated, but as it is, I think it's a nice
alternative to the Python filters. The documentation, sample pipeline, and unit
tests should adequately explain the current feature set (basically
multi-dimensional, min/max/exact value criteria for passing points through to
the output buffer).