Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passthrough filter #743

Merged
merged 1 commit into from
Feb 5, 2015
Merged

Add passthrough filter #743

merged 1 commit into from
Feb 5, 2015

Conversation

chambbj
Copy link
Member

@chambbj chambbj commented Feb 2, 2015

This could obviously be more complicated, but as it is, I think it's a nice
alternative to the Python filters. The documentation, sample pipeline, and unit
tests should adequately explain the current feature set (basically
multi-dimensional, min/max/exact value criteria for passing points through to
the output buffer).

@chambbj
Copy link
Member Author

chambbj commented Feb 2, 2015

Just to clarify, this is not intended to be a full replacement for Python, just a small subset for simple filtering.

@hobu
Copy link
Member

hobu commented Feb 2, 2015

Could this be called filters.sieve?

@chambbj
Copy link
Member Author

chambbj commented Feb 2, 2015

I have no strong feeling on the name. Passthrough is just the analogue in PCL.

@hobu
Copy link
Member

hobu commented Feb 2, 2015

ah, that's fine to keep it aligned then. I think our challenge is that filters itself is probably wrong, since they don't really/always "filter".

@chambbj
Copy link
Member Author

chambbj commented Feb 2, 2015

I still have it in the back of my head to possibly split the filters from the non-filters. I struggle a little with what to call the non-filters. I believe @abellgithub proposed "operations" or something similar.

@gadomski
Copy link
Member

gadomski commented Feb 2, 2015

My two cents: sieve does make more sense than passthrough for me — I had to go look at the source to figure out what passthrough did, but I think I could have intuited sieve.

@chambbj
Copy link
Member Author

chambbj commented Feb 3, 2015

Discussed offline -- this basically just filters a range, and we don't have plans to make it any more complicated than that, so call it a range filter.

This could obviously be more complicated, but as it is, I think it's a nice
alternative to the Python filters. The documentation, sample pipeline, and unit
tests should adequately explain the current feature set (basically
multi-dimensional, min/max/exact value criteria for passing points through to
the output buffer).
@chambbj
Copy link
Member Author

chambbj commented Feb 5, 2015

I'd missed a file rename on this. Otherwise, assuming it passes Travis, it's all ready to go.

hobu added a commit that referenced this pull request Feb 5, 2015
@hobu hobu merged commit 2fade5c into master Feb 5, 2015
@chambbj chambbj deleted the add-passthrough-filter branch February 5, 2015 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants