Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimentID #111

Closed
yannikschaelte opened this issue May 9, 2019 · 2 comments · Fixed by #173
Closed

Remove experimentID #111

yannikschaelte opened this issue May 9, 2019 · 2 comments · Fixed by #173
Labels
visualization

Comments

@yannikschaelte
Copy link
Member

as discussed in #110 , remove the experimentID in favor of datasetID. don't know if a replacement for petab.generate_experiment_id will be needed.
yannikschaelte added a commit that referenced this issue May 9, 2019
@yannikschaelte
fix call to generate exp id (#110)
743d639 
here just making the example work now, deletion of experimentId then in #111
elbaraim pushed a commit that referenced this issue Oct 4, 2019
@yannikschaelte
fix call to generate exp id (#110)
28c0098 
here just making the example work now, deletion of experimentId then in #111
@dweindl
Copy link
Member

dweindl commented Dec 3, 2019

generate_experiment_id can simply be removed or is that meant to changed into something else?

@yannikschaelte
Copy link
Member Author

not that I know of, should be safe to remove.

dweindl added a commit that referenced this issue Dec 3, 2019
@dweindl
Remove obsolete generate_experiment_id.py (Closes #111)
3759d82
dweindl added a commit that referenced this issue Dec 4, 2019
@dweindl
Remove obsolete generate_experiment_id.py (Closes #111)
450f845
dweindl added a commit that referenced this issue Dec 4, 2019
@dweindl
Remove obsolete generate_experiment_id.py (Closes #111)
7eec68e
This was referenced Dec 4, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
visualization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 0.0.0a17 PEtab-dev/PEtab
Release 0.0.0a17 PEtab-dev/PEtab
2 participants
@dweindl @yannikschaelte