-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix generate example #110
Fix generate example #110
Conversation
Release 0.0.0a14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this experiment_id still a thing? I thought that became obsolete with the new plotting config files. Not sure though.
@erikadudki @MerktSimon Is this still a thing (you were working on this, right?)? |
At least for visualization the experimentID does not play a role, because plots are grouped by plotID and for everything else there is DataSetID. |
I think the experimentID can and should be removed. It has been replaced by the more fine-grained datasetID. |
Okay, I'm a little confused... As a non-developer of PEtab, I have a rough idea what Another point is, that the benchmark examples don't have these fields. So, if we want to make them mandatory, we need to rework he PEtab files of the benchmark examples. That's doable, but we have to keep it in mind... |
as far as I understand it, datasetId has in principle the same purpose, primarily for visualizing together data that belong together. If it's not documented, i.e. the full visualizationSpecification file, then this should be done in the petab docs indeed (@MerktSimon @erikadudki). I think nothing will be mandatory, so the files/fields should be marked as optional in the docs. |
here just making the example work now, deletion of experimentId then in #111
No description provided.