Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specific error messages if sbml not well-defined #118

Closed
yannikschaelte opened this issue Aug 5, 2019 · 2 comments · Fixed by #173
Closed

Specific error messages if sbml not well-defined #118

yannikschaelte opened this issue Aug 5, 2019 · 2 comments · Fixed by #173
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@yannikschaelte
Copy link
Member

Since we have some specific sbml requirements, it might be informative for the user to give explicit error messages, e.g. "you need to define sigmas" etc., as far as possible. These things are a bit difficult to detect currently.

@dweindl
Copy link
Member

dweindl commented Aug 5, 2019

Can you provide more details of when and where (stacktrace) that happened and what message you got instead?

@dweindl dweindl added the enhancement New feature or request label Aug 5, 2019
@yannikschaelte
Copy link
Member Author

yannikschaelte commented Aug 5, 2019

so ... not my code, but this is where:

File "/home/paulstapor/pycharm-community-2019.1/helpers/pydev/pydevd.py", line 1741, in <module>
    main()
  File "/home/paulstapor/pycharm-community-2019.1/helpers/pydev/pydevd.py", line 1735, in main
    globals = debugger.run(setup['file'], None, None, is_module)
  File "/home/paulstapor/pycharm-community-2019.1/helpers/pydev/pydevd.py", line 1135, in run
    pydev_imports.execfile(file, globals, locals)  # execute the script
  File "/home/paulstapor/pycharm-community-2019.1/helpers/pydev/pydev_imps/_pydev_execfile.py", line 18, in execfile
    exec(compile(contents+"\n", file, 'exec'), glob, loc)
  File "/home/paulstapor/sedml_import/simulatePetab.py", line 17, in <module>
    petab_problem.get_optimization_to_simulation_parameter_mapping()
  File "/home/paulstapor/anaconda3/envs/PENV/lib/python3.7/site-packages/petab/core.py", line 236, in get_optimization_to_simulation_parameter_mapping
    warn_unmapped=warn_unmapped)
  File "/home/paulstapor/anaconda3/envs/PENV/lib/python3.7/site-packages/petab/core.py", line 508, in get_optimization_to_simulation_parameter_mapping
    row.observableId, override_type='noise')
  File "/home/paulstapor/anaconda3/envs/PENV/lib/python3.7/site-packages/petab/core.py", line 492, in _apply_overrides
    f'{override_type}Parameter{i+1}{observable_id}']
KeyError: 'noiseParameter1_task0_model0_perelson1_V'

solution was to define sigma + noise parameter

@dweindl dweindl added the good first issue Good for newcomers label Aug 5, 2019
@dweindl dweindl self-assigned this Nov 29, 2019
dweindl added a commit that referenced this issue Nov 29, 2019
dweindl added a commit that referenced this issue Nov 29, 2019
This was referenced Dec 4, 2019
dweindl added a commit to PEtab-dev/libpetab-python that referenced this issue Apr 15, 2021
…for_observable (fixes #59)

Revert "More informative error messages in case of wrongly set observable and noise parameters (Closes PEtab-dev/PEtab#118) (PEtab-dev/PEtab#155)"

This reverts commit 8fab85e.
dweindl added a commit to PEtab-dev/libpetab-python that referenced this issue Apr 16, 2021
…for_observable (fixes #59) (#60)

Revert "More informative error messages in case of wrongly set observable and noise parameters (Closes PEtab-dev/PEtab#118) (PEtab-dev/PEtab#155)"

This reverts commit 8fab85e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants