Skip to content

Commit

Permalink
Fix unreachable TypeError in petab.parameter_mapping.apply_overrides_…
Browse files Browse the repository at this point in the history
…for_observable (fixes #59) (#60)

Revert "More informative error messages in case of wrongly set observable and noise parameters (Closes PEtab-dev/PEtab#118) (PEtab-dev/PEtab#155)"

This reverts commit 8fab85e.
  • Loading branch information
dweindl committed Apr 16, 2021
1 parent d481eda commit 74838ec
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions petab/parameter_mapping.py
Original file line number Diff line number Diff line change
Expand Up @@ -360,14 +360,7 @@ def _apply_overrides_for_observable(
"""
for i, override in enumerate(overrides):
overridee_id = f'{override_type}Parameter{i+1}_{observable_id}'
try:
mapping[overridee_id] = override
except KeyError as e:
raise TypeError(f'Cannot override {override_type} parameter '
f'{overridee_id} for observable {observable_id}.'
f'Ensure there exists an {override_type} '
'definition containing the correct number of '
'placeholder parameters.') from e
mapping[overridee_id] = override


def _apply_condition_parameters(par_mapping: ParMappingDict,
Expand Down

0 comments on commit 74838ec

Please sign in to comment.