Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle None in petab.core.split_parameter_replacement_list #121

Closed
dweindl opened this issue Aug 9, 2019 · 0 comments · Fixed by #173
Closed

Handle None in petab.core.split_parameter_replacement_list #121

dweindl opened this issue Aug 9, 2019 · 0 comments · Fixed by #173
Assignees
@dweindl
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@dweindl
Copy link
Member

dweindl commented Aug 9, 2019

Would be convenient if this function could handle None in addition to empty strings, in case column types have not been inferred correctly.

Currently:

"petab/core.py", line 544, in split_parameter_replacement_list
    result = [x.strip() for x in list_string.split(delim) if len(x.strip())]
AttributeError: 'NoneType' object has no attribute 'split'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Release 0.0.0a17 PEtab-dev/PEtab
Release 0.0.0a17 PEtab-dev/PEtab
1 participant
@dweindl