Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: visualizing results using petab.visualize #162

Closed
fbergmann opened this issue Dec 2, 2019 · 5 comments
Closed

documentation: visualizing results using petab.visualize #162

fbergmann opened this issue Dec 2, 2019 · 5 comments
Assignees
Labels
bug Something isn't working visualization

Comments

@fbergmann
Copy link
Contributor

as discussed over in the pyPESTO repo, i'm trying to visualize results obtained by pyPESTO. @yannikschaelte commented, that i should be using the plot_data_and_simulation function you provide with PEtab. It would be nice if that function would take just a petab problem + a data simulation data (frame) in the same format. As that would be exactly the information I have.

but according to the information i should be able to get some result plotted using

data is attached.

data.tsv.txt
cond.tsv.txt

@yannikschaelte
Copy link
Member

it should be possible to pass both data_file_path (for the data) and simulation_file_path (for the simulations). not sure if that changes sth ...

@erikadudki
Copy link
Contributor

I think the issue here is, that the 'observableParameters' column in the data-file is empty. I ran into the same issue recently.
This has to be added into the PEtab visualization functionality, that an empty 'observableParameters' column is allowed.
I'm working on it at the moment.
Thanks for pointing that out!

@dweindl dweindl added bug Something isn't working visualization labels Dec 2, 2019
erikadudki added a commit that referenced this issue Dec 3, 2019
…ile) (#164)

* add handling of empty observableParameters column in measurement file
 
* addresses #162
@erikadudki
Copy link
Contributor

@fbergmann now it should work, could you try it again?

@fbergmann
Copy link
Contributor Author

@erikadudki it took a while to check, as it did not work immidiately. When i just reran the lines from the screenshot above, i still got an empty plot with the warning:

UserWarning: DatasetIds would have been available, but other grouping was requested. Consider using datasetId.

This does make it a bit harder, as most petab files come without a datasetId, and i'd have to generate it in many cases. So it would have been nice if observable_id_list would have worked. But i used datasetId and added the simulation data (here it would have been nice if petab would accepd the measurement column, if no simulatedData column would be present). And with that i got this plot:

This is what i wanted, however I would change the behavior in the drawing, such that the measurement data uses a dashed line and the simulationData a solid line.

@LeonardSchmiester
Copy link
Collaborator

This is what i wanted, however I would change the behavior in the drawing, such that the measurement data uses a dashed line and the simulationData a solid line.

See also #152

plakrisenko added a commit that referenced this issue Jan 14, 2020
plakrisenko added a commit that referenced this issue Jan 14, 2020
…ss dataframes to the visualisation function as an alternative to file paths, fixes #162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working visualization
Projects
None yet
Development

No branches or pull requests

6 participants