Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.0.0a14 #107

Merged
merged 9 commits into from
May 2, 2019
Merged

Release 0.0.0a14 #107

merged 9 commits into from
May 2, 2019

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Apr 28, 2019

No changes to PEtab format.

Python library:

dweindl and others added 7 commits April 5, 2019 23:49
* Fix assert_noise_distributions_valid

TypeError: ufunc 'isnan' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''
Checking for nan with `n` does not work in all cases
#106)

* Perform mapping for simulation and preequilibration condition independently (Fixes #105)

* Refactor, cleanup, add typehints, document

* Move parameter mapping functions to separate module

* Change parameter mapping to dictionaries with parameter IDs

* Apply suggestions from code review

* Fix error type

* Add function to merge preequilibration and simulation parameters and scales
@codecov-io
Copy link

codecov-io commented Apr 28, 2019

Codecov Report

Merging #107 into master will increase coverage by 2.62%.
The diff coverage is 85.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
+ Coverage   57.51%   60.14%   +2.62%     
==========================================
  Files           7        7              
  Lines         758      803      +45     
  Branches      167      173       +6     
==========================================
+ Hits          436      483      +47     
+ Misses        293      292       -1     
+ Partials       29       28       -1
Impacted Files Coverage Δ
petab/version.py 100% <100%> (ø) ⬆️
petab/sbml.py 55.65% <100%> (+0.38%) ⬆️
petab/generate_experiment_id.py 87.5% <100%> (ø) ⬆️
petab/lint.py 42.36% <50%> (+0.49%) ⬆️
petab/parameter_mapping.py 81.74% <81.74%> (ø)
petab/core.py 76.42% <93.87%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9aeecf...398cd4f. Read the comment docs.

@dweindl dweindl changed the title [WIP] Release 0.0.0a14 Release 0.0.0a14 May 2, 2019
Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't look in detail since it should already be fine

@dweindl dweindl merged commit e07857c into master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants