Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dynamic parameter overrides for preequilibration parameters #105

Closed
dweindl opened this issue Apr 10, 2019 · 1 comment
Closed

Fix dynamic parameter overrides for preequilibration parameters #105

dweindl opened this issue Apr 10, 2019 · 1 comment
Assignees
@dweindl

Comments

@dweindl
Copy link
Member

dweindl commented Apr 10, 2019 •
edited
Loading

The current parameter mapping assumes that preequilibration and simulation condition have the same dynamic parameters. So the mapping probably fails in case preequilibration and simulation condition have different dynamic parameter overrides.
@dweindl
Copy link
Member Author

dweindl commented Apr 11, 2019

TODO: In future, the parameter mapping should be performed for each condition separately and not based on (preequilibrationCondition. simulationCondition) tuples.

@dweindl dweindl self-assigned this Apr 12, 2019
dweindl added a commit that referenced this issue Apr 25, 2019
@dweindl
Perform mapping for simulation and preequilibration condition indepen…
87a9e5d 
…dently (Fixes #105)
@dweindl dweindl mentioned this issue Apr 25, 2019
Merged
@dweindl dweindl closed this as completed in 79cde76 May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dweindl