Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend validator to check if all required parameters are present in p… #159

Merged
merged 2 commits into from
Dec 2, 2019

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 1, 2019

…arameter table (Closes #43)

@dweindl dweindl requested a review from a team December 1, 2019 15:57
@codecov-io
Copy link

codecov-io commented Dec 1, 2019

Codecov Report

Merging #159 into develop will decrease coverage by 0.51%.
The diff coverage is 53.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #159      +/-   ##
===========================================
- Coverage    71.78%   71.27%   -0.52%     
===========================================
  Files           12       12              
  Lines         1159     1173      +14     
  Branches       265      268       +3     
===========================================
+ Hits           832      836       +4     
- Misses         279      289      +10     
  Partials        48       48
Impacted Files Coverage Δ
petab/lint.py 50.22% <21.42%> (-1.95%) ⬇️
petab/core.py 79.88% <85.71%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e3366...421d14d. Read the comment docs.

Copy link
Contributor

@erikadudki erikadudki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@dweindl dweindl merged commit eca81a5 into develop Dec 2, 2019
@dweindl dweindl deleted the feature_43_validate_parameter_df branch December 2, 2019 16:28
This was referenced Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants