Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ParameterScale sampler fixes #491 #492

Merged
merged 4 commits into from
Jan 11, 2021
Merged

Conversation

jvanhoefer
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #492 (2370b11) into develop (d948970) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #492   +/-   ##
========================================
  Coverage    78.03%   78.03%           
========================================
  Files           23       23           
  Lines         2295     2295           
  Branches       544      544           
========================================
  Hits          1791     1791           
  Misses         369      369           
  Partials       135      135           
Impacted Files Coverage Δ
petab/parameters.py 82.43% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d948970...2370b11. Read the comment docs.

@jvanhoefer
Copy link
Contributor Author

Hey, sorry for not finishing this up before Christmas.

It seems like @dilpath's bugfix was also the issue in this PR. I added a clarifying sentence in the documentation. To me, this should solve the problems. Are you fine with doing another small release (v.0.1.14), since this issue currently breaks pypesto initial value sampling in the develop branch? (I could take care of that, just want your OK :) )

@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Was unclear/wrong before.
Good to go unless @yannikschaelte or anybody else sees some problem there.

@dweindl
Copy link
Member

dweindl commented Jan 11, 2021

P.S.: Please add a proper pull request description.

@jvanhoefer jvanhoefer changed the title fix ParameterScaleUniform fixes #491 fix ParameterScale sampler fixes #491 Jan 11, 2021
@jvanhoefer jvanhoefer merged commit 59c4216 into develop Jan 11, 2021
@jvanhoefer jvanhoefer deleted the fix_prior_sampling branch January 11, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants