Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatten_timepoint_specific_output_overrides does not support observableParameter overrides as placeholders in noise formulae #234

Closed
dweindl opened this issue Dec 14, 2023 · 0 comments · Fixed by #235
Closed

flatten_timepoint_specific_output_overrides does not support observableParameter overrides as placeholders in noise formulae #234

dweindl opened this issue Dec 14, 2023 · 0 comments · Fixed by #235
Assignees
@dweindl
Labels
bug Something isn't working

Comments

@dweindl
Copy link
Member

dweindl commented Dec 14, 2023

flatten_timepoint_specific_output_overrides does not support observableParameter placeholders in noise formulae.

Related to #231
@dweindl dweindl added the bug Something isn't working label Dec 14, 2023
@dweindl dweindl self-assigned this Dec 14, 2023
@dweindl dweindl mentioned this issue Dec 14, 2023
Closed
dweindl added a commit that referenced this issue Dec 14, 2023
@dweindl
Fix flatten_timepoint_specific_output_overrides not supporting obse…
b55ebad 
…rvableParameter overrides as placeholders in noise formulae

Fixes #234

Also fixes return type annotation, makes test more readable, and uses more informative assertions.
@dweindl dweindl mentioned this issue Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix flatten_timepoint_specific_output_overrides not supporting obse… PEtab-dev/libpetab-python
1 participant
@dweindl