Fix flatten_timepoint_specific_output_overrides not supporting obse…
#235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvableParameter overrides as placeholders in noise formulae Fixes #234 Also fixes return type annotation, makes test more readable, and uses more informative assertions.
dweindl
commented
Dec 14, 2023
| @@ -277,22 +277,21 @@ def flatten_timepoint_specific_output_overrides( | |||
| for field, hyperparameter_type, target in [ | |||
| (NOISE_PARAMETERS, "noiseParameter", NOISE_FORMULA), | |||
| (OBSERVABLE_PARAMETERS, "observableParameter", OBSERVABLE_FORMULA), | |||
| (OBSERVABLE_PARAMETERS, "observableParameter", NOISE_FORMULA), | |||
There was a problem hiding this comment.
Basically, this line was missing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
=======================================
Coverage 76.28% 76.29%
=======================================
Files 34 34
Lines 3188 3189 +1
Branches 774 774
=======================================
+ Hits 2432 2433 +1
Misses 554 554
Partials 202 202 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rvableParameter overrides as placeholders in noise formulae
Fixes #234
Also fixes return type annotation, makes test more readable, and uses more informative assertions.