Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<dimension> tag doesn't work on xml's #640

Open
technodono opened this issue Sep 2, 2020 · 4 comments
Open

<dimension> tag doesn't work on xml's #640

technodono opened this issue Sep 2, 2020 · 4 comments
Labels
feature New feature or request good first issue Good for newcomers reintroduce Reintroduces a feature that was removed

Comments

@technodono
Copy link

technodono commented Sep 2, 2020

I've recently wanted to make a custom map in the end dimension just to spruce up the sky box but this module is currently despite it being a feature still on the docs. Would be nice to see it fixed as it could make maps look much more interesting... this is the code i used:

<dimension>end</dimension>

@Pablete1234 Pablete1234 added feature New feature or request reintroduce Reintroduces a feature that was removed good first issue Good for newcomers labels Sep 3, 2020
@applenick
Copy link
Member

applenick commented Sep 3, 2020

@technodono
I’m fairly certain dimensions can be adjusted by using the <terrain> tag.

<terrain>
     <environment>the_end</environment>
</terrain>

It seems the docs have incorrect info, as environment should work based on the code.
https://pgm.dev/docs/modules/environment/world

If you get a chance to try that out, let me know here if it does work.

Edit:
It actually might be <terrain environment="the_end"/> I can’t check right now, but let me know

@technodono
Copy link
Author

technodono commented Sep 4, 2020

@applenick
I’m fairly certain dimensions can be adjusted by using the <terrain> tag.

<terrain>
     <environment>the_end</environment>
</terrain>

It seems the docs have incorrect info, as environment should work based on the code.
https://pgm.dev/docs/modules/environment/world

If you get a chance to try that out, let me know here if it does work.

Edit:
It actually might be <terrain environment="the_end"/> I can’t check right now, but let me know

No, neither of those work unfotunately :(

@Pugzy
Copy link
Contributor

Pugzy commented Sep 13, 2020

Both ways described in @applenick comment set the dimension (it appears the docs is incorrect showing it as dimension).

<terrain environment="nether"/>
<!-- OR -->
<terrain>
    <environment>nether</dimension>
</terrain>

Setting it to the end has no visual effect (looks the exact same as not specifying, setting it to nether makes everything red, shows a portal effect when respawning, however, when trying this on a regular map the entire world was empty with just a red haze and no world. Never seen a map use this so not sure what the correct implementation would be as far as the world format goes.

image

@technodono
Copy link
Author

@Pugzy well I guess nether works kinda... but you'd expect the end to have it's respective skybox and fog right...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers reintroduce Reintroduces a feature that was removed
Development

No branches or pull requests

4 participants