Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing pre and post action call #77

Closed
jnessier opened this issue Dec 24, 2022 · 3 comments
Closed

Missing pre and post action call #77

jnessier opened this issue Dec 24, 2022 · 3 comments

Comments

@jnessier
Copy link

jnessier commented Dec 24, 2022

I am missing pre and post actions for the controllers. E.g for authentication checks before the action got called. Running pre actions in the constructor of the controller mostly won't work because the request object is not accessible/created then.

Are you interested in a pull request?

@mnapoli
Copy link
Member

mnapoli commented Jan 13, 2023

Is that an official feature in Slim? I don't want to add a custom feature in the bridge, but I'm ok merging it if it's an official feature that we are missing.

@jnessier
Copy link
Author

No, it is not a feature in Slim. But I'm missing pre and post action calls in the controller.

Feel free to cancel the pull request.

@mnapoli
Copy link
Member

mnapoli commented Jan 13, 2023

Got it, thanks for the response.

@mnapoli mnapoli closed this as not planned Won't fix, can't repro, duplicate, stale Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants