Universal/[Require/Disallow]FinalClass: docs/test update for readonly classes #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What with PHP 8.2 introducing `readonly` classes, the metric name `Class declaration type` would become ambiguous as `readonly` is not taken into account for the metric (and doesn't need to be as it doesn't have a direct relationship to `abstract`/`final`). To prevent confusion about what the metric records, the metric name has been updated.
... to ensure the fixer continues to work correctly when the class is also `readonly`.
jrfnl
deleted the
universal/require-disallowfinalclass-allow-for-readonly-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Universal/[Require/Disallow]FinalClass: rename metric
What with PHP 8.2 introducing
readonlyclasses, the metric nameClass declaration typewould become ambiguous asreadonlyis not taken into account for the metric (and doesn't need to be as it doesn't have a direct relationship toabstract/final).To prevent confusion about what the metric records, the metric name has been updated.
Universal/[Require/Disallow]FinalClass: add tests with readonly classes
... to ensure the fixer continues to work correctly when the class is also
readonly.