Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Universal/[Require/Disallow]FinalClass: docs/test update for readonly classes #148

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Universal/[Require/Disallow]FinalClass: docs/test update for readonly classes #148

merged 2 commits into from
Nov 2, 2022

Commits on Nov 2, 2022

  1. Universal/[Require/Disallow]FinalClass: rename metric 

    What with PHP 8.2 introducing `readonly` classes, the metric name `Class declaration type` would become ambiguous as `readonly` is not taken into account for the metric (and doesn't need to be as it doesn't have a direct relationship to `abstract`/`final`).

To prevent confusion about what the metric records, the metric name has been updated.
    @jrfnl
    jrfnl committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    53b1492 View commit details
    Browse the repository at this point in the history

  2. Universal/[Require/Disallow]FinalClass: add tests with readonly classes 

    ... to ensure the fixer continues to work correctly when the class is also `readonly`.
    @jrfnl
    jrfnl committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    9c56dd1 View commit details
    Browse the repository at this point in the history