Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Universal.Operators.DisallowStandalonePostIncrementDecrement sniff #65

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jun 28, 2020

New sniff to disallow the use of post-in/decrements in stand-alone statements and discourage the use of multiple increment/decrement operators in a stand-alone statement.

Post-in/decrement returns the value and in/decrements afterwards.
Pre-in/decrement in/decrements the value and returns afterwards.
Using pre-in/decrement is more in line with the principle of least astonishment
and prevents bugs when code gets moved around at a later point in time.

Includes fixer.
Includes unit tests.
Includes documentation.
Includes metrics.

…sniff

New sniff to disallow the use of post-in/decrements in stand-alone statements and discourage the use of multiple increment/decrement operators in a stand-alone statement.

> Post-in/decrement returns the value and in/decrements afterwards.
> Pre-in/decrement in/decrements the value and returns afterwards.
> Using pre-in/decrement is more in line with the principle of least astonishment
> and prevents bugs when code gets moved around at a later point in time.

Includes fixer.
Includes unit tests.
Includes documentation.
Includes metrics.
@jrfnl jrfnl added this to the 1.0.0-alpha3 milestone Jun 28, 2020
@jrfnl jrfnl merged commit 9ebc9a7 into develop Jun 29, 2020
@jrfnl jrfnl deleted the feature/universal/new-disallow-standalone-post-indecrement-sniff branch June 29, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant