Core: add sniffs to check formatting of increment/decrement operators #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> 1. There should be no space between an increment/decrement operator and the variable it applies to. > 2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. > “Pre” will in/decrement and then return, “post” will return and then in/decrement. > Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around. Refs: * https://make.wordpress.org/core/2020/03/20/updating-the-coding-standards-for-modern-php/ - Increment/decrement operators section * https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#space-usage * https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#increment-decrement-operators * WordPress/wpcs-docs 112 * WordPress/WordPress-Coding-Standards 1511 * squizlabs/PHP_CodeSniffer 2172 * squizlabs/PHP_CodeSniffer 2174 * PHPCSStandards/PHPCSExtra 65 Closes 1511
dingo-d
approved these changes
Dec 7, 2022
GaryJones
approved these changes
Dec 7, 2022
|
True enough, but as it has an auto-fixer, it's a one time switch-over for which I have the commit ready already. |
|
For the record: in WP Core, the |
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Sep 9, 2023
…nts. Note: This is enforced by WPCS 3.0.0: 1. There should be no space between an increment/decrement operator and the variable it applies to. 2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around. References: * [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#increment-decrement-operators WordPress PHP Coding Standards: Increment/decrement operators] * [WordPress/WordPress-Coding-Standards#2130 WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators] Props jrf. See #59161, #58831. Built from https://develop.svn.wordpress.org/trunk@56549 git-svn-id: https://core.svn.wordpress.org/trunk@56061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Sep 9, 2023
…nts. Note: This is enforced by WPCS 3.0.0: 1. There should be no space between an increment/decrement operator and the variable it applies to. 2. Pre-increment/decrement should be favoured over post-increment/decrement for stand-alone statements. “Pre” will in/decrement and then return, “post” will return and then in/decrement. Using the “pre” version is slightly more performant and can prevent future bugs when code gets moved around. References: * [https://developer.wordpress.org/coding-standards/wordpress-coding-standards/php/#increment-decrement-operators WordPress PHP Coding Standards: Increment/decrement operators] * [WordPress/WordPress-Coding-Standards#2130 WPCS: PR #2130 Core: add sniffs to check formatting of increment/decrement operators] Props jrf. See #59161, #58831. Built from https://develop.svn.wordpress.org/trunk@56549 git-svn-id: http://core.svn.wordpress.org/trunk@56061 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core: add sniffs to check formatting of increment/decrement operators
Refs:
Universal.Operators.DisallowStandalonePostIncrementDecrementsniff PHPCSStandards/PHPCSExtra#65Closes #1511
CS: clean up codebase for new rules / pre-increment