PHP 8.0: verified support for "mixed" type declarations#163
Merged
Conversation
jrfnl
force-pushed
the
feature/php8-mixed-type-add-unit-tests
branch
2 times, most recently
from
3260633 to
2470e36
Compare
…PHP 8 "mixed" type No changes needed to the actual method, the parameter type is already handled correctly.
…PHP 8 "mixed" return type No changes needed to the actual method, the return type is already handled correctly.
… property type No changes needed to the actual method, the type is already handled correctly.
jrfnl
force-pushed
the
feature/php8-mixed-type-add-unit-tests
branch
from
2470e36 to
cf89158
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests to the following methods to verify that the new
mixedtype declaration is handled correctly (hint: it is).BCFile::getMethodParameters()FunctionDeclarations::getParameters()(viaBCFile::getMethodParameters())BCFile::getMethodProperties()FunctionDeclarations::getProperties()(viaBCFile::getMethodProperties())BCFile::getMemberProperties()Variables::getMemberProperties()(viaBCFile::getMemberProperties())