PHP 8.0 | FunctionDeclarations::getParameters(): add support for constructor property promotion#169
Merged
jrfnl merged 1 commit intoJul 17, 2020
Conversation
…tor property promotion This commit adds support for constructor property promotion to the `FunctionDeclarations::getParameters()` method. This change introduces two new keys - `property_visibility` and `visibility_token` - to the return array which will only be included if constructor property promotion is detected. The method does not check whether property promotion is _valid_ in the function/method in which it is used. That is not the concern of this method. Changes along the same lines as included in this PR will also be pulled upstream to PHPCS itself. Once the upstream PR has been merged, those changes will also be applied to the `BCFile::getMethodParameters()` method. Includes unit tests. Ref: https://wiki.php.net/rfc/constructor_promotion
jrfnl
deleted the
functiondeclarations/getparameters-php8-constructor-property-promotion
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for constructor property promotion to the
FunctionDeclarations::getParameters()method.This change introduces two new keys -
property_visibilityandvisibility_token- to the return array which will only be included if constructor property promotion is detected.The method does not check whether property promotion is valid in the function/method in which it is used. That is not the concern of this method.
Changes along the same lines as included in this PR will also be pulled upstream to PHPCS itself. Once the upstream PR has been merged, those changes will also be applied to the
BCFile::getMethodParameters()method.Includes unit tests.
Ref: https://wiki.php.net/rfc/constructor_promotion