BCFile::getMethodParameters(): sync with PHPCS / constructor property promotion support #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… promotion support PR 169 added support for PHP 8.0 constructor property promotion to the `FunctionDeclarations::getParameters()` method. Upstream PR 3152 added the same to the PHPCS native `File::getMethodParameters()` method. As that PR has now been merged, this commit syncs the upstream changes into the `BCFile::getMethodParameters()` method and moves the unit tests from the "Diff" tests to the BCFile test class.
jrfnl
deleted the
feature/getmethodparam-constr-prop-promotion-sync-with-phpcs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #169 added support for PHP 8.0 constructor property promotion to the
FunctionDeclarations::getParameters()method.Upstream PR squizlabs/PHP_CodeSniffer#3152 added the same to the PHPCS native
File::getMethodParameters()method.As that PR has now been merged, this commit syncs the upstream changes into the
BCFile::getMethodParameters()method and moves the unit tests from the "Diff" tests to the BCFile test class.