Collections: deprecate $OONameTokens in favour of namespacedNameTokens() #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate the `$OONameTokens` property in favour of a new `Collections::namespacedNameTokens()` method. PHP 8.0 introduces three new tokens to represent identifier names. As those tokens will not always be available, a property can't handle this. In anticipation of the introduction of the new tokens, I'm deprecating the `Collections::$OONameTokens` property to prevent BC breaks at a later point in time. Includes adding unit tests for the new method. Includes switching out existing uses of the deprecated property for the new method.
jrfnl
deleted the
feature/collections-deprecate-oonametokens-add-namespacednametoken-method
branch
jrfnl
added a commit
that referenced
this pull request
Dec 24, 2022
... and remove the remaining methods without logic (but which had a name change one way or the other). Follow-up after #202, #311. Includes updating the tests: * Mostly remove method specific tests and move those to the `PropertyBasedTokenArraysTest`. * For the "type" token arrays - update the order of the expected arrays.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
$OONameTokensproperty in favour of a newCollections::namespacedNameTokens()method.PHP 8.0 introduces three new tokens to represent identifier names. As those tokens will not always be available, a property can't handle this.
In anticipation of the introduction of the new tokens, I'm deprecating the
Collections::$OONameTokensproperty to prevent BC breaks at a later point in time.Includes adding unit tests for the new method.
Includes switching out existing uses of the deprecated property for the new method.