Merged
Conversation
... which provided the basis of the compatibility layer with PHPCS 2.x. This is no longer needed now PHPCS 3.7.1 is the minimum PHPCS version.
... and remove the remaining methods without logic (but which had a name change one way or the other). Follow-up after #202, #311. Includes updating the tests: * Mostly remove method specific tests and move those to the `PropertyBasedTokenArraysTest`. * For the "type" token arrays - update the order of the expected arrays.
…ted methods Use the `T_FN` token directly instead. Follow up to #347.
…ose()` method Use the the `scope_opener`/`scope_closer` on the `T_DECLARE` token instead. Follow up to #347.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the PHPCS23Utils standard
... which provided the basis of the compatibility layer with PHPCS 2.x. This is no longer needed now PHPCS 3.7.1 is the minimum PHPCS version.
Tokens\Collections: remove the deprecated $magicConstants property.
Use the PHPCS native
Tokens::$magicConstantsproperty or thePHPCSUtils\BackCompat\BCTokens::magicConstants()method instead.Follow up on #106, #172, #311.
Tokens\Collections: remove the deprecated $OONameTokens property.
Use the
PHPCSUtils\Tokens\Collections::namespacedNameTokens()method instead.Follow up to #113, #202.
Tokens\Collections: remove previously deprecated methods
Follow up to #347.
Tokens\Collections: make deprecated properties private
... and remove the remaining methods without logic (but which had a name change one way or the other).
Follow-up after #202, #311.
Includes updating the tests:
PropertyBasedTokenArraysTest.Utils\FunctionDeclarations: remove the deprecated arrow function related methods
Use the
T_FNtoken directly instead.Follow up to #347.
Utils\ControlStructures: remove the deprecated
getDeclareScopeOpenClose()methodUse the the
scope_opener/scope_closeron theT_DECLAREtoken instead.Follow up to #347.