BCFile/various methods: compatibility with the PHP 8 identifier name tokenization#213
Merged
jrfnl merged 1 commit intoSep 13, 2020
Conversation
…tokenization While PHPCS itself won't backfill, nor start supporting the PHP 8 identifier name tokens until PHPCS 4.x, for compatibility with PHPCS < 3.5.7 in combination with PHP 8, the `BCFile::getMethodParameters()`, `BCFile::isReference()`, `BCFile::findExtendedClassName()` and `BCFile::findImplementedInterfaceNames()` methods still need adjusting to allow for cross-version compatibility. Relevant unit tests for this were already added for most methods in PR 205. For the `isReference()` method, select unit tests are now moved from the `Diff` test file to the `BCFile` test files.
jrfnl
deleted the
php-8.0/bcfile-various-identifier-name-compatibility
branch
September 13, 2020 20:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While PHPCS itself won't backfill, nor start supporting the PHP 8 identifier name tokens until PHPCS 4.x, for compatibility with PHPCS < 3.5.7 in combination with PHP 8, the
BCFile::getMethodParameters(),BCFile::isReference(),BCFile::findExtendedClassName()andBCFile::findImplementedInterfaceNames()methods still need adjusting to allow for cross-version compatibility.Relevant unit tests for this were already added for most methods in PR #205.
For the
isReference()method, select unit tests are now moved from theDifftest file to theBCFiletest files.