PHP 8.0 | BCFile/FunctionDeclarations::get[Method]Parameters(): add tests with trailing commas #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests with trailing commas Since PHP 8.0, trailing commas are allowed in parameter lists and closure `use` lists. This adds some tests to verify the methods handle this correctly and to safeguard this. Ref: * https://wiki.php.net/rfc/trailing_comma_in_parameter_list * https://wiki.php.net/rfc/trailing_comma_in_closure_use_list
jrfnl
force-pushed
the
php8.0/bcfile/getmethodparameters-add-tests-with-trailing-commas
branch
from
75c869b
to
8e35043
Compare
jrfnl
deleted the
php8.0/bcfile/getmethodparameters-add-tests-with-trailing-commas
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PHP 8.0, trailing commas are allowed in parameter lists and closure
uselists.This adds some tests to verify the methods handle this correctly and to safeguard this.
Ref: