Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8.0 | BCFile/FunctionDeclarations::get[Method]Parameters(): add tests with trailing commas #355

Merged
merged 1 commit into from
Oct 15, 2022
Merged

PHP 8.0 | BCFile/FunctionDeclarations::get[Method]Parameters(): add tests with trailing commas #355

merged 1 commit into from
Oct 15, 2022

Commits on Oct 15, 2022

  1. PHP 8.0 | BCFile/FunctionDeclarations::get[Method]Parameters(): add t… 

    …ests with trailing commas

Since PHP 8.0, trailing commas are allowed in parameter lists and closure `use` lists.

This adds some tests to verify the methods handle this correctly and to safeguard this.

Ref:
* https://wiki.php.net/rfc/trailing_comma_in_parameter_list
* https://wiki.php.net/rfc/trailing_comma_in_closure_use_list
    @jrfnl
    jrfnl committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    8e35043 View commit details
    Browse the repository at this point in the history