PHP 8.1: add support for readonly properties #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for readonly keyword > ... in constructor property promotion. > > Note: the `property_readonly` key will always be added when constructor property promotion has been detected. The `readonly_token` only when the `readonly` token has actually been found. > > Includes unit tests. Ref: * squizlabs/PHP_CodeSniffer 3516
…donly Includes: * Updating the `Collections::$propertyModifierKeyword` property to allow for the `T_READONLY` token. Includes unit tests. Ref: * squizlabs/PHP_CodeSniffer 3480 * squizlabs/PHP_CodeSniffer 3513 * squizlabs/PHP_CodeSniffer 3515 * squizlabs/PHP_CodeSniffer 3584 Co-authored-by: Jaroslav Hanslík <kukulich@kukulich.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 | BCFile/FunctionDeclarations::get[Method]Parameters(): allow for readonly keyword
Ref:
PHP 8.1 | Variables::getMemberProperties(): detect if property is readonly
Includes:
Collections::$propertyModifierKeywordproperty to allow for theT_READONLYtoken.Includes unit tests.
Ref:
readonlykeyword squizlabs/PHP_CodeSniffer#3480readonlyearlier to fix some bugs squizlabs/PHP_CodeSniffer#3584