QA: make all classes final #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "class vs sniff name" matcher in the PHPCS autoloader does not handle sniffs classes extending other sniffs well. Now, while this "standard" doesn't actually contain any sniffs, the utilities in this library are not intended to be extended anyway, aside from the explicitly `abstract` base sniffs. So, with that in mind, I'm making all classes in this library `final`, with the exception of some select test classes (the `BCFile` ones as those need to be extended to safeguard that the PHPCSUtils native functionality mirrors the PHPCS native functionality). If anyone has issues with any particular class now being `final`, please report this ASAP and please include a good use-case of why that particular class should not be `final`.
... as there can never be a (grand-)child class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QA: make all classes final
The "class vs sniff name" matcher in the PHPCS autoloader does not handle sniffs classes extending other sniffs well.
Now, while this "standard" doesn't actually contain any sniffs, the utilities in this library are not intended to be extended anyway, aside from the explicitly
abstractbase sniffs.So, with that in mind, I'm making all classes in this library
final, with the exception of some select test classes (theBCFileones as those need to be extended to safeguard that the PHPCSUtils native functionality mirrors the PHPCS native functionality).If anyone has issues with any particular class now being
final, please report this ASAP and please include a good use-case of why that particular class should not befinal.QA: don't use static for LSB in final class
... as there can never be a (grand-)child class.