UtilityMethodTestCase::getTargetToken(): change to a static method#382
Merged
jrfnl merged 1 commit intoOct 23, 2022
Merged
Conversation
The method effectively was already `static` as it didn't use `$this`. Making it explicitly static will allow for using it in "set up before class" test fixture methods. This is particularly useful when a "cache" of information would need to be set up using the same code as the code under test. If this is done in a "set up" fixture, the code being run would be counted for the code coverage calculation, while when don in "set up before class", the code being run will _not_ be counted for code coverage, allowing for cleaner coverage reports. Includes introducing some minor variations in the pre-existing tests to safeguard that both static calls as well as non-static calls to the method are supported.
jrfnl
deleted the
testutils/utilitymethodtestcase-make-gettargettoken-method-static
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method effectively was already
staticas it didn't use$this. Making it explicitly static will allow for using it in "set up before class" test fixture methods.This is particularly useful when a "cache" of information would need to be set up using the same code as the code under test. If this is done in a "set up" fixture, the code being run would be counted for the code coverage calculation, while when don in "set up before class", the code being run will not be counted for code coverage, allowing for cleaner coverage reports.
Includes introducing some minor variations in the pre-existing tests to safeguard that both static calls as well as non-static calls to the method are supported.