UtilityMethodTestCase::getTargetToken(): throw exception when method called without tokenized test case file #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…called without tokenized test case file Follow up on 382 which made the method `static`. As the method _could_ conceivably now be called _before_ the `UtilityMethodTestCase::setUpTestFile()`, let's throw an exception with an informative error message if that's the case. Includes: * A new `PHPCSUtils\Exceptions\TestFileNotFound` exception class. * Tests for both the new exception as well as the implementation of that exception in the `UtilityMethodTestCase::getTargetToken()` method.
jrfnl
deleted the
testutils/utilitymethodtestcase-gettargettoken-stabilize
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #382 which made the
UtilityMethodTestCase::getTargetToken()methodstatic.As the method could conceivably now be called before the
UtilityMethodTestCase::setUpTestFile(), let's throw an exception with an informative error message if that's the case.Includes:
PHPCSUtils\Exceptions\TestFileNotFoundexception class.UtilityMethodTestCase::getTargetToken()method.