File::find[Start|End]OfStatement(): add QA tests #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the test case file
This commit adds two QA tests to find potential bugs in the `File::find[Start|End]OfStatement()` methods. 1. It adds a test to ensure that the return value of `File::findStartOfStatement()` is never _after_ the passed `$start` stack pointer. 2. It adds a test to ensure that the return value of `File::findEndOfStatement()` is never _before_ the passed `$start` stack pointer. The tests use the existing test code, but tests all non-empty tokens within the file. Note: this test doesn't test that the stack pointer returned is _correct_, only that it _could_ be correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up on #502
File::findStartOfStatement(): fix some unintentional parse errors in the test case file
File::find[Start|End]OfStatement(): add QA tests
This commit adds two QA tests to find potential bugs in the
File::find[Start|End]OfStatement()methods.File::findStartOfStatement()is never after the passed$startstack pointer.File::findEndOfStatement()is never before the passed$startstack pointer.The tests use the existing test code, but tests all non-empty tokens within the file.
Note: this test doesn't test that the stack pointer returned is correct, only that it could be correct.
Suggested changelog entry
N/A