Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File::find[Start|End]OfStatement(): add QA tests #509

Merged
merged 2 commits into from
May 22, 2024
Merged

File::find[Start|End]OfStatement(): add QA tests #509

merged 2 commits into from
May 22, 2024

Commits on May 21, 2024

  1. File::findStartOfStatement(): fix some unintentional parse errors in … 

    …the test case file
    @jrfnl
    jrfnl committed May 21, 2024
    Configuration menu
    Copy the full SHA
    83373f9 View commit details
    Browse the repository at this point in the history

  2. File::find[Start|End]OfStatement(): add QA tests 

    This commit adds two QA tests to find potential bugs in the `File::find[Start|End]OfStatement()` methods.

1. It adds a test to ensure that the return value of `File::findStartOfStatement()` is never _after_ the passed `$start` stack pointer.
2. It adds a test to ensure that the return value of `File::findEndOfStatement()` is never _before_ the passed `$start` stack pointer.

The tests use the existing test code, but tests all non-empty tokens within the file.

Note: this test doesn't test that the stack pointer returned is _correct_, only that it _could_ be correct.
    @jrfnl
    jrfnl committed May 21, 2024
    Configuration menu
    Copy the full SHA
    a82f02e View commit details
    Browse the repository at this point in the history