Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR2/PSR12/ControlStructureSpacing: don't listen for T_ELSE #83

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Nov 11, 2023

Description

Recreation of upstream PR squizlabs/PHP_CodeSniffer#3872:

No functional changes.

These sniffs only concerns themselves with control structures which take parentheses, so listening for T_ELSE is unnecessary as the sniffs will never do anything for that token (they each bow out on no 'parenthesis_opener'/'parenthesis_closer' found).

Suggested changelog entry

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

No functional changes.

These sniffs only concerns themselves with control structures which take parentheses, so listening for `T_ELSE` is unnecessary as the sniffs will never do anything for that token (they each bow out on no 'parenthesis_opener'/'parenthesis_closer' found).
@jrfnl jrfnl force-pushed the feature/psr2-controlstructurespacing-remove-t_else branch from ee9df63 to f4ac654 Compare December 4, 2023 15:59
@jrfnl jrfnl merged commit 54fef11 into master Dec 4, 2023
65 checks passed
@jrfnl jrfnl deleted the feature/psr2-controlstructurespacing-remove-t_else branch December 4, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant