Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0: NewIniDirectives: account for configurable string length in getTraceAsString() #1191

Merged
merged 1 commit into from
Aug 9, 2020

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Jul 30, 2020

  • zend.exception_string_param_max_len
    . New INI directive to set the maximum string length in an argument of a
    stringified stack strace.

Refs:

Includes unit tests.

Related to #809

…getTraceAsString()

> - zend.exception_string_param_max_len
>   . New INI directive to set the maximum string length in an argument of a
>   stringified stack strace.

Refs:
* https://wiki.php.net/rfc/throwable_string_param_max_len
* https://github.com/php/php-src/blob/47e4001976f3ff85a6d479df39dc82d4ceb18b19/UPGRADING#L957-L959
* php/php-src#5769
* php/php-src@07db641

Includes unit tests.
@jrfnl jrfnl added enhancement PR: quick merge PR only contains relatively simple changes PR: ready for review labels Jul 30, 2020
@jrfnl jrfnl added this to the 10.0.0 milestone Jul 30, 2020
@jrfnl jrfnl requested a review from wimg July 30, 2020 18:32
@wimg wimg merged commit 0a105a9 into develop Aug 9, 2020
@wimg wimg deleted the php-8.0/newinidirectives-gettraceasstring-rfc branch August 9, 2020 18:44
@jrfnl jrfnl removed PR: quick merge PR only contains relatively simple changes PR: ready for review labels Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants