[RFC] Make string length for getTraceAsString() configurable #5769
Conversation
TysonAndre
force-pushed
the
throwable_string_length_limit
branch
from
5fd7888
to
e2615b9
Compare
TysonAndre
changed the title
TysonAndre
force-pushed
the
throwable_string_length_limit
branch
2 times, most recently
from
55fe472
to
b6d7cbb
Compare
main/php_globals.h
Outdated
| @@ -18,6 +18,7 @@ | |||
| #define PHP_GLOBALS_H | |||
|
|
|||
| #include "zend_globals.h" | |||
| #include "php.h" | |||
There was a problem hiding this comment.
It's been a while, I think I added this to fix a compilation error I saw when php_globals.h was loaded without loading a header it depended on first.
But that may have been limited to an older version of this.
There was a problem hiding this comment.
Ah, why is this in php_globals.h at all though? This is Zend functionality, so it should be in zend_globals.h. As is, this causes a layering violation by including PHP headers in Zend.
There was a problem hiding this comment.
Oh, now I remember.
The issue was that main/php.h includes the #define PHPAPI, and this file contains extern PHPAPI int core_globals_id; , so if a C file loaded only main/php_globals.h, it would have a compilation error.
That's out of the scope of this RFC, so I'm taking it out.
There was a problem hiding this comment.
Just to make sure this didn't get lost in a race condition, did you see my comment on moving this from php_globals.h into zend_globals.h?
There was a problem hiding this comment.
Just to make sure this didn't get lost in a race condition, did you see my comment on moving this from php_globals.h into zend_globals.h?
I'm not sure if I understood exactly how you wanted me to implement this, and I'd think that would be more appropriate outside of this PR. It might be easier for you to create a PR/commit than to explain it in that much detail.
Also, that predated my response
The issue was that main/php.h includes the #define PHPAPI, and this file contains extern PHPAPI int core_globals_id; , so if a C file loaded only main/php_globals.h, it would have a compilation error.
There was a problem hiding this comment.
Also, I took out the include "php.h"
There was a problem hiding this comment.
Sorry for being unclear. What I meant is to move the declaration of zend_long exception_string_param_max_len; from php_core_globals into zend_executor_globals, which is the same place where exception_ignore_args is defined. We should not have dependencies on PHP headers from inside Zend.
There was a problem hiding this comment.
Sorry for being unclear. What I meant is to move the declaration of zend_long exception_string_param_max_len; from php_core_globals into zend_executor_globals, which is the same place where exception_ignore_args is defined. We should not have dependencies on PHP headers from inside Zend.
That sounds doable and makes sense
There was a problem hiding this comment.
Sorry for being unclear. What I meant is to move the declaration of zend_long exception_string_param_max_len; from php_core_globals into zend_executor_globals, which is the same place where exception_ignore_args is defined. We should not have dependencies on PHP headers from inside Zend.
Okay, done in bcc7ade
|
Please see 9250abf for the correct format to use in php.ini-production/development. This was messed up for zend.exception_ignore_args a bit. |
TysonAndre
force-pushed
the
throwable_string_length_limit
branch
2 times, most recently
from
a40e22c
to
dabdeec
Compare
TysonAndre
force-pushed
the
throwable_string_length_limit
branch
from
dabdeec
to
a004e00
Compare
Add a `zend.exception_string_param_max_len` ini setting. (same suffix as `log_errors_max_len`) Allow values between 0 and 1000000 bytes. For example, with zend.exception_string_param_max_len=0, "" would represent the empty string, and "..." would represent something longer than the empty string. Previously, this was hardcoded as exactly 15 bytes. Discussion: https://externals.io/message/110717
TysonAndre
force-pushed
the
throwable_string_length_limit
branch
from
a004e00
to
bcc7ade
Compare
…getTraceAsString() > - zend.exception_string_param_max_len > . New INI directive to set the maximum string length in an argument of a > stringified stack strace. Refs: * https://wiki.php.net/rfc/throwable_string_param_max_len * https://github.com/php/php-src/blob/47e4001976f3ff85a6d479df39dc82d4ceb18b19/UPGRADING#L957-L959 * php/php-src#5769 * php/php-src@07db641 Includes unit tests.
Add a
zend.exception_string_param_max_lenini setting.(same suffix as
log_errors_max_len)Allow values between 0 and 1000000 bytes.
For example, with zend.exception_string_param_max_len=0,
"" would represent the empty string, and "..." would represent something
longer than the empty string.
Previously, this was hardcoded as exactly 15 bytes.
RFC: https://wiki.php.net/rfc/throwable_string_param_max_len
Discussion: https://externals.io/message/110717