ForbiddenNames: allow for the final keyword in trait use statements
#402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the RFC which introduced traits, the `final` modifier is supported as well. The sniff did so far not account for this and would throw a false positive for use of the reserved keyword `final` in that case. Example code: ```php use sayHello as final; use sayHello as final myFinalHello; ``` Ref: https://wiki.php.net/rfc/horizontalreuse#visibility Includes a new usecase test file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the RFC which introduced traits, the
finalmodifier is supported as well. The sniff did so far not account for this and would throw a false positive for use of the reserved keywordfinalin that case.Example code:
Ref: https://wiki.php.net/rfc/horizontalreuse#visibility
Includes a new usecase test file.