PHP 7.3: New sniff to detect references in list constructs #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
php-7.3/new-list-reference-assignments-sniff
branch
from
0a054c8
to
8736b79
Compare
|
Rebased & verified categorization and sniff name. |
jrfnl
force-pushed
the
php-7.3/new-list-reference-assignments-sniff
branch
from
8736b79
to
34656ce
Compare
> Array destructuring now supports reference assignments using the syntax `[&$a, [$b, &$c]] = $d`. The same is also supported for `list()`. Refs: * https://wiki.php.net/rfc/list_reference_assignment * php/php-src@6d4de4c * https://github.com/php/php-src/blob/9b89b09b24ffe29c2b6de24c3d9b21df4f2a9de0/UPGRADING#L58-L60
jrfnl
force-pushed
the
php-7.3/new-list-reference-assignments-sniff
branch
from
34656ce
to
b767c63
Compare
wimg
approved these changes
Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs:
Now #655 has been merged, this PR can be pulled as it extends the sniff added in #655 as it needs the same basic logic.