PHP 7.4/RemovedConstants: handle deprecated magic quote related filter constant #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r constant > Magic quotes were deprecated all the way back in PHP 5.3 and later removed in PHP 5.4. The filter extension implements a sanitization filter that mimics this behavior of `magic_quotes` by calling `addslashes()` on the input in question. > > In PHP 7.3 `add_slashes (FILTER_SANITIZE_ADD_SLASHES)` was added as a new alias for this filter, to allow us to move away from the `magic_quotes` terminology. > > Proposed action: Emit a deprecation notice each time the `FILTER_SANITIZE_MAGIC_QUOTES` filter is used and advise users to use the `add_slashes (FILTER_SANITIZE_ADD_SLASHES)` filter instead. This constant is to be removed in PHP 8.0. Refs: * https://wiki.php.net/rfc/deprecations_php_7_4#filter_sanitize_magic_quotes * php/php-src#4390 * php/php-src@cd2f2cd
jrfnl
added
enhancement
PR: quick merge
39 tasks
wimg
reviewed
Jul 22, 2019
wimg
approved these changes
Jul 22, 2019
delete-merged-branch
bot
deleted the
php-7.4/deprecations/remove-constants-filter
branch
jrfnl
removed
PR: ready for review
PR: quick merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This constant is to be removed in PHP 8.0.
Refs:
Related to #808