Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP8.1 Fix issue with passing NULL value for locale into string function #2272

Merged
merged 1 commit into from Sep 15, 2022
Merged

PHP8.1 Fix issue with passing NULL value for locale into string function #2272

merged 1 commit into from Sep 15, 2022

Conversation

seamuslee001
Copy link
Contributor

Description

This fixes an issue in PHP8.1 where passing a NULL value to strlen() function is deprecated

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@NelinD
Copy link

NelinD commented Aug 1, 2022

We need this!

@Ilyasoad
Copy link

Ilyasoad commented Aug 1, 2022

we all need this

@garethellis36 garethellis36 mentioned this pull request Sep 14, 2022
Merged
3 tasks
@PowerKiKi PowerKiKi merged commit 2ee6df6 into PHPOffice:develop Sep 15, 2022
@seamuslee001 seamuslee001 deleted the php81_locale branch September 15, 2022 22:29
@PowerKiKi PowerKiKi mentioned this pull request Sep 16, 2022
Closed
@Progi1984 Progi1984 added this to the v0.19.0 milestone Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@seamuslee001 @NelinD @Ilyasoad @PowerKiKi @Progi1984