Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Edit Address Label dialog does not accept ENTER keyboard button press #1606

Closed
ambassador000 opened this issue May 7, 2020 · 0 comments · Fixed by #1610
Closed

[Bug] Edit Address Label dialog does not accept ENTER keyboard button press #1606

ambassador000 opened this issue May 7, 2020 · 0 comments · Fixed by #1610
Assignees
@random-zebra
Labels
Feature Request
Milestone
4.2.0

Comments

@ambassador000
Copy link

editLabelBug1
random-zebra added a commit to random-zebra/PIVX that referenced this issue May 8, 2020
@random-zebra
[GUI] Make more dialogs inherit from FocusedDialog
cf9ee7b 
- AddNewContactDialog (closes PIVX-Project#1606)
- MasterNodeWizardDialog
- MnInfoDialog
- ReceiveDialog
- RequestDialog
- SendChangeAddressDialog
- SendCustomFeeDialog
@random-zebra random-zebra mentioned this issue May 8, 2020
Merged
@random-zebra random-zebra self-assigned this May 8, 2020
@random-zebra random-zebra added this to the 5.0.0 milestone May 9, 2020
@furszy furszy closed this as completed in 7cb8107 May 13, 2020
furszy added a commit that referenced this issue May 13, 2020
@furszy
Merge #1610: [GUI][UX] Add accept/close keyboard controls to all dialogs
9ac68cf 
26b5dc2 [GUI][Refactor] Dismiss dialogs with QDialog::reject vs QWidget::close (random-zebra)
7cb8107 [GUI] Make more dialogs inherit from FocusedDialog (random-zebra)
9acda36 [GUI] Make DefaultDialog and TxDetailDialog child of FocusedDialog (random-zebra)
bc579f7 [GUI] Introduce FocusedDialog generic class (random-zebra)

Pull request description:

  This creates a generic extension of QDialog, named `FocusedDialog`, with the property of having the focus on show and filtering key press events to call `accept()` with ENTER/RETURN and `close()` with ESC (ref: #1392).
  Removes code duplication in `DefaultDialog` and `TxDetailDialog` by making them child classes of FocusedDialog.
  Also add this ability to other dialogs as well:
  - `AddNewContactDialog` (closes #1606)
  - `MasterNodeWizardDialog`
  - `MnInfoDialog`
  - `ReceiveDialog`
  - `RequestDialog`
  - `SendChangeAddressDialog`
  - `SendCustomFeeDialog`

ACKs for top commit:
  Fuzzbawls:
    ACK 26b5dc2
  furszy:
    Tested ACK 26b5dc2 and merging.

Tree-SHA512: 43a8f74969a55e5c9f9119721f94f54b33ba44291c6e06e7603f63fb4d1a959fce8cf17e6e63811e2b550ce0c62e06d5831acdc279de20fe914c97a71c0638d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@random-zebra random-zebra

Labels
Feature Request
Projects
None yet
Milestone
4.2.0
Development

Successfully merging a pull request may close this issue.

[GUI][UX] Add accept/close keyboard controls to all dialogs random-zebra/PIVX
2 participants
@random-zebra @ambassador000