[GUI][UX] Add accept/close keyboard controls to all dialogs #1610
Conversation
to be extended by all QDialog child classes that are meant to be focused on show and need keyboard control (enter/esc) to accept/close.
- AddNewContactDialog (closes PIVX-Project#1606) - MasterNodeWizardDialog - MnInfoDialog - ReceiveDialog - RequestDialog - SendChangeAddressDialog - SendCustomFeeDialog
random-zebra
force-pushed
the
202005_GUI_focuseddialog
branch
from
cf9ee7b
to
7cb8107
Compare
|
Rebased for conflicts after merge of #1604 |
src/qt/pivx/sendconfirmdialog.h
Outdated
| @@ -37,10 +36,10 @@ class TxDetailDialog : public QDialog | |||
| void setDisplayUnit(int unit){this->nDisplayUnit = unit;}; | |||
|
|
|||
| public Q_SLOTS: | |||
| void acceptTx(); | |||
| void accept() override; | |||
| void close(); | |||
There was a problem hiding this comment.
I thought so too, but the compiler complained.
That's probably because the QWidget::close() function (inherited by QDialog) returns a boolean value, not void.
Actually, have a point of discussion about this: I think it would be better to not use close() at all here, but rather resort to QDialog::reject() and override that one.
There was a problem hiding this comment.
yeah but we should double check something. The reject method is the one that sets the return value to rejected but it hides the dialog, it doesn't close it.
QT documentation is not clear over the difference between hide and close.
There was a problem hiding this comment.
both accept and reject call QDialog::done() and Qt docs state:
If this dialog is shown with exec(), done() also causes the local event loop to finish, and exec() to return r.
As with QWidget::close(), done() deletes the dialog if the Qt::WA_DeleteOnClose flag is set. If the dialog is the application's main widget, the application terminates. If the dialog is the last window closed, the QApplication::lastWindowClosed() signal is emitted.
There was a problem hiding this comment.
Added 26b5dc2 with the change
This creates a generic extension of QDialog, named
FocusedDialog, with the property of having the focus on show and filtering key press events to callaccept()with ENTER/RETURN andclose()with ESC (ref: #1392).Removes code duplication in
DefaultDialogandTxDetailDialogby making them child classes of FocusedDialog.Also add this ability to other dialogs as well:
AddNewContactDialog(closes [Bug] Edit Address Label dialog does not accept ENTER keyboard button press #1606)MasterNodeWizardDialogMnInfoDialogReceiveDialogRequestDialogSendChangeAddressDialogSendCustomFeeDialog