[GUI] Accept dialogs with ENTER, reject with ESC

[random-zebra]

Ref: #1163 (review)

Completes the ability to accept/dismiss modal dialogs with the keyboard, including:

• confirmation dialogs (DefaultDialog)
• tx detail / tx confirmation dialogs (TxDetailDialog)

[Fuzzbawls]

Good QOL improvement.

utACK d88eaef

[furszy]

Alternative implementation to the grabKeyboard and releaseKeyboard. Just override QDialog::keyPressEvent virtual method and set focus over the dialog when it's being shown.

Tested changes patch (did it only over one dialog, can easily be applied to -squashed into- each of the previous commits):

Index: src/qt/pivx/defaultdialog.h
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- src/qt/pivx/defaultdialog.h	(date 1584632051000)
+++ src/qt/pivx/defaultdialog.h	(date 1584717124293)
@@ -19,6 +19,8 @@
     explicit DefaultDialog(QWidget *parent = nullptr);
     ~DefaultDialog();
 
+    void showEvent(QShowEvent *event) override;
+
     void setText(QString title = "", QString message = "", QString okBtnText = "", QString cancelBtnText = "");
 
     bool isOk = false;
@@ -29,7 +31,7 @@
 private:
     Ui::DefaultDialog *ui;
 protected:
-    bool event(QEvent* event) override;
+    void keyPressEvent(QKeyEvent *e) override;
 };
 
 #endif // DEFAULTDIALOG_H
Index: src/qt/pivx/defaultdialog.cpp
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- src/qt/pivx/defaultdialog.cpp	(date 1584632051000)
+++ src/qt/pivx/defaultdialog.cpp	(date 1584717244585)
@@ -38,7 +38,11 @@
     connect(ui->btnEsc, SIGNAL(clicked()), this, SLOT(close()));
     connect(ui->btnCancel, SIGNAL(clicked()), this, SLOT(close()));
     connect(ui->btnSave, &QPushButton::clicked, this, &DefaultDialog::accept);
-    grabKeyboard();
+}
+
+void DefaultDialog::showEvent(QShowEvent *event)
+{
+    setFocus();
 }
 
 void DefaultDialog::setText(QString title, QString message, QString okBtnText, QString cancelBtnText)
@@ -60,7 +64,7 @@
     QDialog::accept();
 }
 
-bool DefaultDialog::event(QEvent* event)
+void DefaultDialog::keyPressEvent(QKeyEvent *event)
 {
     if (event->type() == QEvent::KeyPress) {
         QKeyEvent* ke = static_cast<QKeyEvent*>(event);
@@ -69,11 +73,9 @@
         // Detect Esc key press
         if (ke->key() == Qt::Key_Escape) close();
     }
-    return QDialog::event(event);
 }
 
 DefaultDialog::~DefaultDialog()
 {
-    releaseKeyboard();
     delete ui;
 }

[random-zebra]

Applied @furszy's patch to TxDetail and Default dialogs. Squashed / rebased on master.

[furszy]

ACK 37e73fe