[Backport] 4.1.0 backports #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default `-printtoconsole` to false for the GUI. GUI programs should not print to the console unnecessarily. For example, when launched by the window manager, the output might end up in the X session log file, resulting in duplicate logging. On Windows, it is pointless as well because bitcoin-qt isn't a console application. Github-Pull: PIVX-Project#1530 Rebased-From: 9f969e9
Github-Pull: PIVX-Project#1425 Rebased-From: 452a461
Github-Pull: PIVX-Project#1429 Rebased-From: 0f0ccba
Github-Pull: PIVX-Project#1527 Rebased-From: acdccc5
Because of the parent function 'QWidget::mousePressEvent'. Github-Pull: PIVX-Project#1529 Rebased-From: f94c3ed
Github-Pull: PIVX-Project#1529 Rebased-From: 23e01d7
gitian's use of apt-cacher server on the host doesn't work when using Windows 10's WSL subsystem. This adds a check to see if the ubuntu OS version is from "Microsoft" (which indicates it is a WSL environment), then uses the boolean result to disable the use of apt-cacher if true. Github-Pull: PIVX-Project#1536 Rebased-From: 45ce02e
These strings are placeholders, treat them as such by not sending them to Transifex for localization. Github-Pull: PIVX-Project#1535 Rebased-From: 219317f
Github-Pull: PIVX-Project#1538 Rebased-From: 3422f22
node data pulled from primary DNS seeder pivx.seed.fuzzbawls.pw Github-Pull: PIVX-Project#1538 Rebased-From: 8b490ec
Github-Pull: PIVX-Project#1537 Rebased-From: 9583c9e
backports bitcoin/bitcoin@08ebdba and adds/moves missing flags in initialize_datadir Github-Pull: PIVX-Project#1550 Rebased-From: b948b62
- alias cannot contain spaces or #. But any other character should be allowed. - the port number should be fixed per-network. No need to add a validator there Github-Pull: PIVX-Project#1545 Rebased-From: 0e3c18f
- validateMasternodeIP: validate IPv4, IPv6 and onion addresses - remove port validation: it's fixed, no need to check Github-Pull: PIVX-Project#1545 Rebased-From: de45ddc
Github-Pull: PIVX-Project#1543 Rebased-From: 1c1ee43
Github-Pull: PIVX-Project#1556 Rebased-From: 2e012ae
v3 onion addresses are 256 bits, which is currently beyond what our P2P protocol allows in `addr` messages. Until such time that [BIP155] (https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki) can be implemented, note in the tor.md doc that the `-externalip` configuration flag should not be used with v3 onion addresses. Github-Pull: PIVX-Project#1573 Rebased-From: c31b056
Github-Pull: PIVX-Project#1551 Rebased-From: 15b56a2
Github-Pull: PIVX-Project#1551 Rebased-From: ca99eaa
Github-Pull: PIVX-Project#1551 Rebased-From: 581fab6
nFeeNeeded is an absolute value (feePerKb * txKb). Github-Pull: PIVX-Project#1575 Rebased-From: 08092dd
Given the strict timestamp checks enforced with POS TimeProtocol v2 (introduced with PIVX-Project#1002: a block cannot have a timestamp earlier than previous blocks and cannot be more than 15 seconds in the future), we don't need the complex (and error-prone) logic of ComputeTimeSmart. We can, instead, simply rely on the blocktime, which already ensures a proper ordering for the transactions. Github-Pull: PIVX-Project#1565 Rebased-From: 3f31b4f
Github-Pull: PIVX-Project#1565 Rebased-From: db99c41
Github-Pull: PIVX-Project#1565 Rebased-From: b1dc5d3
Github-Pull: PIVX-Project#1565 Rebased-From: 0c581fb
Github-Pull: PIVX-Project#1574 Rebased-From: 2a47123
Github-Pull: PIVX-Project#1574 Rebased-From: a10c0f7
Github-Pull: PIVX-Project#1577 Rebased-From: 7ac2aee
Github-Pull: PIVX-Project#1577 Rebased-From: f50918e
Github-Pull: PIVX-Project#1577 Rebased-From: c67fcec
Github-Pull: PIVX-Project#1578 Rebased-From: a5d3e8d
backports bitcoin/bitcoin@04b8773 Github-Pull: PIVX-Project#1578 Rebased-From: 677015a
Github-Pull: PIVX-Project#1580 Rebased-From: df9fc17
Github-Pull: PIVX-Project#1581 Rebased-From: b8a613a
Github-Pull: PIVX-Project#1576 Rebased-From: d063a7f
Github-Pull: PIVX-Project#1576 Rebased-From: 03be61e
Since the fee can be set to a value equal to minTxFee Github-Pull: PIVX-Project#1576 Rebased-From: b8fad43
pre-4.1 release update of the copyright headers Github-Pull: PIVX-Project#1583 Rebased-From: 8108470
This action connection was incorrectly commented out when switching to the new QT5 `connect` syntax. Fix it now by using a simple lambda. Github-Pull: PIVX-Project#1594 Rebased-From: 32867b2
Github-Pull: PIVX-Project#1591 Rebased-From: 940f3f3
Prioritize the action described by the button: - if "Select All", then verify that all entries are checked, otherwise check them - if "Unselect All", then verify that all entries are unchecked, otherwise uncheck them. Github-Pull: PIVX-Project#1595 Rebased-From: 34422fc
Pulls all translations for languages at or above 80% completion. Since this is the first time we've used a minimum completion threshold, this also removes all languages with less than 80% completion. Github-Pull: PIVX-Project#1590 Rebased-From: 036a7b1
Github-Pull: PIVX-Project#1599 Rebased-From: 1ee7398
Github-Pull: PIVX-Project#1599 Rebased-From: b1d423b
Github-Pull: PIVX-Project#1599 Rebased-From: 150c8f4
Fixes a bug that prevented the editing of Cold Staking address labels in the address book due to the passing of an empty purpose, which `CWallet::ParseIntoAddress()` needs in order to determine if an address is a cold staking type address. Github-Pull: PIVX-Project#1588 Rebased-From: 805e436
The current sending flow clears and/or overwrites the user-supplied address label multiple times, including when doing final address validation after clicking the send button. This results in the entered label never being used. This stops the default clear and the overzealous replacing/setting of the label text. Github-Pull: PIVX-Project#1589 Rebased-From: 80aba61
furszy
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the
4.1branch up to date with all the merged PRs intended for the 4.1.0 release