[Doc] Note that v3 onion addresses are not supported #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v3 onion addresses are 256 bits, which is currently beyond what our P2P protocol allows in `addr` messages. Until such time that [BIP155] (https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki) can be implemented, note in the tor.md doc that the `-externalip` configuration flag should not be used with v3 onion addresses.
random-zebra
added
the
Needs Backport
furszy
approved these changes
Apr 26, 2020
Fuzzbawls
added a commit
to Fuzzbawls/PIVX
that referenced
this pull request
May 5, 2020
v3 onion addresses are 256 bits, which is currently beyond what our P2P protocol allows in `addr` messages. Until such time that [BIP155] (https://github.com/bitcoin/bips/blob/master/bip-0155.mediawiki) can be implemented, note in the tor.md doc that the `-externalip` configuration flag should not be used with v3 onion addresses. Github-Pull: PIVX-Project#1573 Rebased-From: c31b056
random-zebra
removed
the
Needs Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3 onion addresses are 256 bits, which is currently beyond what our P2P
protocol allows in
addrmessages. Until such time that BIP155 can beimplemented, note in the tor.md doc that the
-externalipconfigurationflag should not be used with v3 onion addresses.