[GUI][Bug] Don't clear address label during send address validation #1589
Conversation
Fuzzbawls
added
the
Needs Backport
src/qt/pivx/send.cpp
Outdated
| @@ -727,7 +727,8 @@ void SendWidget::onContactsClicked(SendMultiRow* entry) | |||
| menuContacts->setWalletModel(walletModel, AddressTableModel::Send); | |||
| connect(menuContacts, &ContactsDropdown::contactSelected, [this](QString address, QString label) { | |||
| if (focusedEntry) { | |||
| focusedEntry->setLabel(label); | |||
| if (!label.isNull() && label != "(no label)") | |||
There was a problem hiding this comment.
When this is happening? it shouldn't never happen.
An address coming from the contacts menu always has a label. Otherwise it wouldn't be stored as a contact.
There was a problem hiding this comment.
i was seeing null labels in my early testing of this fix, but not after re-testing with a fresh wallet. I've left the check for the string literal (no label) because there really isn't a point in populating the label lineedit with that.
The string literal used here is also used when adding addresses to the address book when the user has not provided a label of their own
There was a problem hiding this comment.
Looking at the current code, the problem would arise when the label field is already complete.
When a contact is selected, the address will be replaced but the label will remain being the same, which could cause confusion as the two addresses would appear to have the same label.
If we are not going to populate the (no label) string, we should clear the label edit line.
The current sending flow clears and/or overwrites the user-supplied address label multiple times, including when doing final address validation after clicking the send button. This results in the entered label never being used. This stops the default clear and the overzealous replacing/setting of the label text.
Fuzzbawls
force-pushed
the
2020_fix-address-label-use
branch
from
d9721b3
to
80aba61
Compare
The current sending flow clears and/or overwrites the user-supplied address label multiple times, including when doing final address validation after clicking the send button. This results in the entered label never being used. This stops the default clear and the overzealous replacing/setting of the label text. Github-Pull: PIVX-Project#1589 Rebased-From: 80aba61
random-zebra
removed
the
Needs Backport
The current sending flow clears and/or overwrites the user-supplied
address label multiple times, including when doing final address
validation after clicking the send button. This results in the entered
label never being used.
This stops the default clear and the overzealous replacing/setting of
the label text.