Skip to content

Commit

Permalink
correct some warnings and spellings
Browse files Browse the repository at this point in the history
  • Loading branch information
ebekker committed Aug 4, 2020
1 parent 6ef1523 commit d6e3ddc
Show file tree
Hide file tree
Showing 4 changed files with 29 additions and 4 deletions.
19 changes: 19 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,35 @@
"PKCS",
"UPSERT",
"Xunit",
"acmesharp",
"acmesharpcore",
"authz",
"bkkr",
"blockrdp",
"chlng",
"choco",
"dd'T'HH",
"deserializes",
"dpkg",
"finalizer",
"integtests",
"ldconfig",
"mailto",
"mkdir",
"msbuild",
"myapp",
"mycertificate",
"nist",
"nupkg",
"openssl",
"popd",
"pushd",
"pwsh",
"requ",
"stateful",
"uncomment",
"wasapl",
"webclient",
"zyborg"
]
}
4 changes: 2 additions & 2 deletions src/ACMESharp/Protocol/Constants.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ static Constants()
/// <summary>
/// Date Time format used by ACME <c>notBefore</c> and <c>notAfter</c>
/// fields, as defined by
/// <see cref="https://tools.ietf.org/html/rfc3339">RFC3339</see> and
/// <see cref="https://tools.ietf.org/html/rfc3339#ref-ISO8601">ISO 8601</see>.
/// <see href="https://tools.ietf.org/html/rfc3339">RFC3339</see> and
/// <see href="https://tools.ietf.org/html/rfc3339#ref-ISO8601">ISO 8601</see>.
/// </summary>
public const string Rfc3339DateTimeFormat = "yyyy-MM-dd'T'HH:mm:ss.fffK";

Expand Down
8 changes: 7 additions & 1 deletion src/examples/ACMECLI/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ Create a new Account; this will dump the Account details afterwards

Create a new Order with a primary DNS and 2 alternates; this will dump
the details for how to handle each Challenge response using the DNS method

```shell
> acmecli --dns myapp.example.com --dns myapp-0.example.com --dns myapp-1.example.com --challenge-type dns-01
```
Expand All @@ -79,27 +80,32 @@ the expected response -- you may have to wait a bit before the
DNS TTL values expire and the correct response (or any response)
is finally returned from a DNS query. You can use the tool to confirm
the Challenge has been implemented

```shell
> acmecli --dns myapp.example.com --dns myapp-0.example.com --dns myapp-1.example.com --challenge-type dns-01 --test-challenges
```

Now it's time to submit the Challenge answers so that the ACME CA can test
them authorize your account to create certificates with associated DNS names.
```shell
> acmecli --dns myapp.example.com --dns myapp-0.example.com --dns myapp-1.example.com --answer-challenges
```
Now we finalize the Order -- this will also create a new
private key and generate the CSR to submit to the CA.
```shell
> acmecli --dns myapp.example.com --dns myapp-0.example.com --dns myapp-1.example.com --finalize
```
Finally, save the complete certificate chain and corresponding
private key to a PKCS#12 format file with NO password.
```shell
> acmecli --dns myapp.example.com --dns myapp-0.example.com --dns myapp-1.example.com --export-pfx mycertificate.pfx --export-pfx-password " "
```
## Invoke in _One Fell Swoop_
Alternatively, you can invoke the tool once with some additional options that indicate
Expand Down Expand Up @@ -137,4 +143,4 @@ This example program can be used to request multiple certificates with different
combinations of DNS names, but it does not handle the case of issuing different
certificates with the same names, such as when a certificate expires. To do that
you would need to delete the state data that's saved to disk for a particular
order.
order.
2 changes: 1 addition & 1 deletion tools/appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ install:
& sudo ACCEPT_EULA=Y apt-get -y upgrade
## Unfortunately Ubuntu 16.04 does NOT offer OpenSSL 1.1 as a
## standard package so we need to install it oursevles, as per:
## standard package so we need to install it ourselves, as per:
## https://stackoverflow.com/a/44789238/5428506
pushd ..
wget https://www.openssl.org/source/openssl-1.1.0g.tar.gz
Expand Down

0 comments on commit d6e3ddc

Please sign in to comment.