Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(torch): pin the version of pytorch #184

Merged
merged 6 commits into from
Mar 29, 2023

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented Mar 28, 2023

Description

  1. Pin the version of pytorch

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

Gaiejj and others added 3 commits March 28, 2023 14:31
* feat(statistics tools): support statistics tools for experiments launched by omnisafe (PKU-Alignment#157)

* docs: update API documentation

* chore: clean the code

* fix: fix duplicate files

* fix: delete duplicate conf.py

* docs: update tools docs

* chore: clean the docs

* docs: update app docs

* fix: fix conf.py

* fix: fix cli docs

* docs: update omnisafe usage

* fix: [pre-commit.ci] auto fixes [...]

* refactor: refactor docs structure

* docs(foundations): rename docs file

* docs: update introduction

* fix: [pre-commit.ci] auto fixes [...]

* fix: fix spelling

* fix: [pre-commit.ci] auto fixes [...]

* fix: fix code block

* docs: update comment

---------

Co-authored-by: muchvo <118189931+muchvo@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: muchvo <borongzh@gmail.com>
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f6b5aa4) 86.42% compared to head (ea40952) 86.42%.

❗ Current head ea40952 differs from pull request most recent head c1081c0. Consider uploading reports for the commit c1081c0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #184   +/-   ##
=======================================
  Coverage   86.42%   86.42%           
=======================================
  Files          82       82           
  Lines        4095     4095           
=======================================
  Hits         3539     3539           
  Misses        556      556           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@XuehaiPan XuehaiPan added the dependency Something related to package dependencies label Mar 28, 2023
@XuehaiPan XuehaiPan changed the title chore: restrict the version of pytorch deps(torch): pin the version of pytorch Mar 28, 2023
pyproject.toml Outdated Show resolved Hide resolved
Copy link
Member

@XuehaiPan XuehaiPan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also update the requirements.txt and conda-recipe.yaml.

@XuehaiPan XuehaiPan self-requested a review March 28, 2023 14:27
Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@friedmainfunction friedmainfunction merged commit 1574db6 into PKU-Alignment:dev Mar 29, 2023
@friedmainfunction friedmainfunction deleted the pyproject branch March 29, 2023 12:33
muchvo added a commit that referenced this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency Something related to package dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants