Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experiment grid): fix file path problem when using gpu in experiment grid #194

Merged
merged 8 commits into from
Mar 31, 2023

Conversation

muchvo
Copy link
Collaborator

@muchvo muchvo commented Mar 30, 2023

Description

  1. Fix file path problem when using gpu in the experiment grid.

Motivation and Context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
You can use the syntax close #15213 if this solves the issue #15213

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.
  • I have reformatted the code using make format. (required)
  • I have checked the code using make lint. (required)
  • I have ensured make test pass. (required)

Gaiejj and others added 5 commits March 28, 2023 14:31
* feat(statistics tools): support statistics tools for experiments launched by omnisafe (PKU-Alignment#157)

* docs: update API documentation

* chore: clean the code

* fix: fix duplicate files

* fix: delete duplicate conf.py

* docs: update tools docs

* chore: clean the docs

* docs: update app docs

* fix: fix conf.py

* fix: fix cli docs

* docs: update omnisafe usage

* fix: [pre-commit.ci] auto fixes [...]

* refactor: refactor docs structure

* docs(foundations): rename docs file

* docs: update introduction

* fix: [pre-commit.ci] auto fixes [...]

* fix: fix spelling

* fix: [pre-commit.ci] auto fixes [...]

* fix: fix code block

* docs: update comment

---------

Co-authored-by: muchvo <118189931+muchvo@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: muchvo <borongzh@gmail.com>
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.40 🎉

Comparison is base (5e91fb7) 85.99% compared to head (e56f71f) 86.39%.

❗ Current head e56f71f differs from pull request most recent head e6017d0. Consider uploading reports for the commit e6017d0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #194      +/-   ##
==========================================
+ Coverage   85.99%   86.39%   +0.40%     
==========================================
  Files          82       82              
  Lines        4226     4169      -57     
==========================================
- Hits         3634     3602      -32     
+ Misses        592      567      -25     
Impacted Files Coverage Δ
omnisafe/common/statistics_tools.py 88.48% <50.00%> (-1.82%) ⬇️
omnisafe/common/experiment_grid.py 86.88% <75.00%> (+0.29%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@zmsn-2077 zmsn-2077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@Gaiejj Gaiejj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@muchvo muchvo merged commit 05a114a into PKU-Alignment:dev Mar 31, 2023
4 checks passed
@muchvo muchvo deleted the fix_gpu_grid branch March 31, 2023 10:08
muchvo added a commit that referenced this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codestyle update codestyple
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] When I use the experiment grid in GPU, exps with the same file are saved separately
3 participants